On Thu, 04 Sep 2008 10:04:04 -0500 Scott Wood <[EMAIL PROTECTED]> wrote:
> Martyn Welch wrote: > > On Tue, 2 Sep 2008 13:27:09 -0500 > > Scott Wood <[EMAIL PROTECTED]> wrote: > > > >> On Mon, Sep 01, 2008 at 11:27:59AM +0100, Martyn Welch wrote: > >>> +static __initdata struct of_device_id of_bus_ids[] = { > >>> + { .compatible = "simple-bus", }, > >>> + { .type = "serial", }, > >>> + { .type = "soc", }, > >>> + { .type = "i2c", }, > >> i2c and serial don't belong here, and soc is redundant with simple-bus. > >> > > > > I agree about the i2c and serial, although I need the soc entry for the i2c > > devices to be found during the platform scan. > > Not if the soc node has simple-bus in its compatible, which I thought I > remembered yours did. > Um, it will have in the next revision of the patch set ;-) Martyn -- Martyn Welch MEng MPhil MIET (Principal Software Engineer) T:+44(0)1327322748 GE Fanuc Intelligent Platforms Ltd, |Registered in England and Wales Tove Valley Business Park, Towcester, |(3828642) at 100 Barbirolli Square, Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB VAT:GB 729849476 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev