On Sat, 12 Apr 2025 14:49:38 +0200, J. Neuschäfer wrote:
> This patch rewrites pmc.txt into YAML format. Descriptive texts are
> expanded or shortened in a few places to better fit today's conventions.
>
> The list of compatible strings (and combinations of them) is based on
> existing device trees in arch/powerpc as well as compatible strings
> already mentioned in the plain-text version of the binding.
>
> One thing I didn't handle are soc-clk@... nodes as seen in
> Documentation/devicetree/bindings/powerpc/fsl/pmc.yaml.
>
> Signed-off-by: J. Neuschäfer <j...@posteo.net>
> ---
> Changes in v2:
> - Rebase on v6.15-rc1
> - Link to v1:
> https://lore.kernel.org/r/20250315-fslpmc-yaml-v1-1-10ba354a8...@posteo.net
> ---
>
> Note: The examples include a consumer (sata@19000), to demonstrate how
> sleep specifiers work. I've heard that "unrelated" nodes in examples are
> generally discouraged, but I'm not sure if it's better to keep it or to
> drop it in this example.
> ---
> .../devicetree/bindings/powerpc/fsl/pmc.txt | 63 --------
> .../devicetree/bindings/powerpc/fsl/pmc.yaml | 159
> +++++++++++++++++++++
> 2 files changed, 159 insertions(+), 63 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/powerpc/fsl/pmc.example.dtb:
sata@19000 (fsl,mpc8377-sata): 'sleep' does not match any of the regexes:
'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/ata/fsl,pq-sata.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/powerpc/fsl/pmc.example.dtb:
sata@19000 (fsl,mpc8377-sata): 'cell-index' is a required property
from schema $id: http://devicetree.org/schemas/ata/fsl,pq-sata.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250412-fslpmc-yaml-v2-1-98c0948a2...@posteo.net
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
