On Tue, 20 May 2025 16:50:30 -0500
Bjorn Helgaas <helg...@kernel.org> wrote:
> From: Karolina Stolarek <karolina.stola...@oracle.com>
>
> Some existing logs in pci_print_aer() log with error severity by default.
> Convert them to depend on error type (consistent with rest of AER logging).
>
> Signed-off-by: Karolina Stolarek <karolina.stola...@oracle.com>
> Signed-off-by: Bjorn Helgaas <bhelg...@google.com>
> Tested-by: Krzysztof Wilczyński <kwilczyn...@kernel.org>
> Reviewed-by: Kuppuswamy Sathyanarayanan
> <sathyanarayanan.kuppusw...@linux.intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvi...@linux.intel.com>
One comment inline. It is painful to have a non trivial comment
that says we didn't pass a parameter for 'reason X' when maybe
it would be simpler to just pass it and not care that it always
takes the same value?
Either way this is fine.
Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
> ---
> drivers/pci/pcie/aer.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index f5e9961d2c63..4cdcf0ebd86d 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -788,15 +788,21 @@ void pci_print_aer(struct pci_dev *dev, int
> aer_severity,
> layer = AER_GET_LAYER_ERROR(aer_severity, status);
> agent = AER_GET_AGENT(aer_severity, status);
>
> - pci_err(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", status, mask);
> + aer_printk(info.level, dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n",
> + status, mask);
> __aer_print_error(dev, &info);
> - pci_err(dev, "aer_layer=%s, aer_agent=%s\n",
> - aer_error_layer[layer], aer_agent_string[agent]);
> + aer_printk(info.level, dev, "aer_layer=%s, aer_agent=%s\n",
> + aer_error_layer[layer], aer_agent_string[agent]);
>
> if (aer_severity != AER_CORRECTABLE)
> - pci_err(dev, "aer_uncor_severity: 0x%08x\n",
> - aer->uncor_severity);
> + aer_printk(info.level, dev, "aer_uncor_severity: 0x%08x\n",
> + aer->uncor_severity);
>
> + /*
> + * pcie_print_tlp_log() uses KERN_ERR, but we only call it when
> + * tlp_header_valid is set, and info.level is always KERN_ERR in
> + * that case.
I wonder if it's easier to just pass the level in than have the
comment?
> + */
> if (tlp_header_valid)
> pcie_print_tlp_log(dev, &aer->header_log, dev_fmt(" "));
> }
