On Thu, 2025-08-07 at 13:34 +0200, Lukas Wunner wrote:
> On Thu, Aug 07, 2025 at 12:15:32PM +0200, Niklas Schnelle wrote:
> > With pci_uevent_ers() handling PCI_ERS_RESULT_NEED_RESET the result of
> > error_detected() can be used in pci_uevent_ers() even if drivers request
> > a reset. This aligns EEH's behavior with both AER.
>
> I guess the sentence is supposed to end with "and s390"?
Yes had it there and then realized that this is only true after the
last patch, did a bad job of adjusting.
>
> I would have recounted the history a bit, e.g.:
>
> Ever since uevent support was added for AER and EEH with commit
> 856e1eb9bdd4 ("PCI/AER: Add uevents in AER and EEH error/resume"), it
> reported PCI_ERS_RESULT_NONE as the result of ->error_detected() to
> user space.
>
> Commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for
> udev") subsequently amended AER to report the actual return value of
> ->error_detected().
>
> Make the same change to EEH to align it with AER (and s390 error
> recovery).
Thanks for figuring out the history, I'll incorporate this and send a
v5.
>
> > Suggested-by: Lukas Wunner <lu...@wunner.de>
> > Link: https://lore.kernel.org/linux-pci/aip6likjor9kl...@wunner.de/
> > Signed-off-by: Niklas Schnelle <schne...@linux.ibm.com>
>
> Reviewed-by: Lukas Wunner <lu...@wunner.de>
Thanks for the R-b.
