On Wed, Aug 06, 2025 at 03:56:07PM +1000, Andrew Donnellan wrote:
> Until commit 6c85f52b10fd ("kvm/ppc: IRQ disabling cleanup"),
> kvmppc_prepare_to_enter() was called with interrupts already disabled by
> the caller, which was documented in the comment above the function.
>
> Post-cleanup, the function is now called with interrupts enabled, and
> disables interrupts itself.
>
> Fix the comment to reflect the current behaviour.
>
> Fixes: 6c85f52b10fd ("kvm/ppc: IRQ disabling cleanup")
> Signed-off-by: Andrew Donnellan <a...@linux.ibm.com>
> ---
> arch/powerpc/kvm/powerpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index 153587741864..2ba057171ebe 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -69,7 +69,7 @@ int kvm_arch_vcpu_should_kick(struct kvm_vcpu *vcpu)
>
> /*
> * Common checks before entering the guest world. Call with interrupts
> - * disabled.
> + * enabled.
> *
> * returns:
> *
> --
> 2.50.1
>
>
Good catch
Reviewed-by: Gautam Menghani <gau...@linux.ibm.com>
Thanks,
Gautam
