>> Replace the opencoded for_each_cpu(cpu, cpu_online_mask) loop with the >> more readable and equivalent for_each_online_cpu(cpu) macro. >> >> Signed-off-by: Fushuai Wang <wangfush...@baidu.com> >> --- >> drivers/soc/fsl/qbman/qman_test_stash.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/soc/fsl/qbman/qman_test_stash.c >> b/drivers/soc/fsl/qbman/qman_test_stash.c >> index f4d3c2146f4f..6f7597950aa3 100644 >> --- a/drivers/soc/fsl/qbman/qman_test_stash.c >> +++ b/drivers/soc/fsl/qbman/qman_test_stash.c >> @@ -103,7 +103,7 @@ static int on_all_cpus(int (*fn)(void)) >> { >> int cpu; >> >> - for_each_cpu(cpu, cpu_online_mask) { >> + for_each_online_cpu(cpu) { >> struct bstrap bstrap = { >> .fn = fn, >> .started = ATOMIC_INIT(0) > > Yes. This change makes sense given that for_each_online_cpu expands into the > same. > > Why not do for the remaining ones too?
I???m working on updating the remaining instances as well. To keep the commits clear, I???m sending separate patches for each file/subsystem. Regards, Wang. > linux_tip$ grep -Rw "for_each_cpu" * | grep cpu_online_mask > arch/riscv/kernel/unaligned_access_speed.c: for_each_cpu(cpu, > cpu_online_mask) { > arch/riscv/kernel/unaligned_access_speed.c: for_each_cpu(cpu, > cpu_online_mask) { > drivers/soc/fsl/qbman/qman_test_stash.c: for_each_cpu(cpu, > cpu_online_mask) { ** current patch addresses this. > drivers/infiniband/hw/hfi1/sdma.c: for_each_cpu(cpu, cpu_online_mask) { > drivers/cpuidle/cpuidle-tegra.c: for_each_cpu(lcpu, cpu_online_mask) { > include/rv/da_monitor.h: for_each_cpu(cpu, cpu_online_mask) { > kernel/trace/trace_osnoise.c: for_each_cpu(cpu, cpu_online_mask) { > kernel/trace/trace_osnoise.c: for_each_cpu(cpu, cpu_online_mask) { > > > Rest everyone seems to have moved. > linux_tip$ grep -Rw "for_each_online_cpu" * | wc > 416 1141 23047