On Fri, Oct 31, 2025, Rick P Edgecombe wrote: > On Thu, 2025-10-30 at 13:09 -0700, Sean Christopherson wrote: > > v4: > > - Collect reviews/acks. > > - Add a lockdep assertion in kvm_tdp_mmu_map_private_pfn(). [Yan] > > - Wrap kvm_tdp_mmu_map_private_pfn() with CONFIG_KVM_GUEST_MEMFD=y. [test > > bot] > > - Improve (or add) comments. [Kai, and probably others] > > - s/spte/mirror_spte to make it clear what's being passed in > > - Update set_external_spte() to take @mirror_spte as well. [Yan] > > - Move the KVM_BUG_ON() on tdh_mr_extend() failure to the end. [Rick] > > - Take "all" the locks in tdx_vm_ioctl(). [Kai] > > - WARN if KVM attempts to map SPTEs into an invalid root. [Yan] > > - Use tdx_flush_vp_on_cpu() instead of tdx_disassociate_vp() when freeing > > a vCPU in VCPU_TD_STATE_UNINITIALIZED state. [Yan] > > Do you want someone to follow up with a v2 of this after the series lands? > (with > Binbin's verbiage comments incorporated)
Feel free to send a v2 now. Or just reply to Binbin's mail with the updated comment. > https://lore.kernel.org/kvm/[email protected]/#t
