Le 16/11/2025 à 03:44, Ma Ke a écrit :
***ATTENTION, Sopra Steria Group cannot confirm the identity of this email
sender (SPF record failure). This might be a fake email from an attacker, if
you have any doubts report and delete the email.***
***ATTENTION, Sopra Steria Group ne peut pas confirmer l’identité de l’émetteur
de ce message (SPF record failure). Il pourrait s’agir d’un faux message, à
détruire si vous avez un doute ***
pika_dtm_thread() acquires client through of_find_i2c_device_by_node()
but fails to release it in error handling path. This could result in a
reference count leak, preventing proper cleanup and potentially
leading to resource exhaustion. Add put_device() to release the
reference in the error handling path.
It is not really an error path, it is the termination of the kthread.
Found by code review.
Cc: [email protected]
Fixes: 3984114f0562 ("powerpc/warp: Platform fix for i2c change")
Signed-off-by: Ma Ke <[email protected]>
Reviewed-by: Christophe Leroy <[email protected]>
---
arch/powerpc/platforms/44x/warp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/platforms/44x/warp.c
b/arch/powerpc/platforms/44x/warp.c
index a5001d32f978..6f674f86dc85 100644
--- a/arch/powerpc/platforms/44x/warp.c
+++ b/arch/powerpc/platforms/44x/warp.c
@@ -293,6 +293,8 @@ static int pika_dtm_thread(void __iomem *fpga)
schedule_timeout(HZ);
}
+ put_device(&client->dev);
+
return 0;
}
--
2.17.1
