On Mon, Dec 29, 2025 at 07:35:18PM +0100, Christophe Leroy (CS GROUP) wrote:
Le 28/12/2025 à 23:35, Andrew Morton a écrit :
On Wed, 24 Dec 2025 17:25:24 +0530 Sourabh Jain <[email protected]>
wrote:
Note for backporting: This fix is a partial retrieval of the commit
mentioned in the Fixes tag. It is only valid once the change referenced
by the Depends-on tag is present. When backporting this patch, the
commit mentioned in the Depends-on tag must be included first.
Link:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20250121150419.1342794-1-sourabhjain%40linux.ibm.com%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C93a8f925fc024ff9c3fe08de46616c3b%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639025581404027066%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=3iVUdaMBWhExKkDiV%2BBfYufPTKva1dVikhyQShOq7mc%3D&reserved=0
[1]
Link:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20250128043358.163372-1-sourabhjain%40linux.ibm.com%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C93a8f925fc024ff9c3fe08de46616c3b%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639025581404053206%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=GamDe2R87SdpFurnj9Cmt9wOQtkGLgIO1z7nl5QPxgY%3D&reserved=0
[2]
Fixes: c2833a5bf75b ("hugetlbfs: fix changes to command line processing")
Depends-on: 2354ad252b66 ("powerpc/mm: Update default hugetlb size early")
This will be the first "Depends-on:" in history. Which is a hint that
we're doing something wrong. This innovation will surely fool any
downstream automation. Let's use existing tools if possible.
What do you mean by "first in history" ? Do you mean it's never been
used before ? As far as I can see it has been used several times
already. First one was in 2014 with commit a0855054e59b ("iwlwifi:
dvm: drop non VO frames when flushing")
Sasha, do tools use it ?
The standard way to annotate dependencies is outlined in the docs:
To send additional instructions to the stable team, use a shell-style inline
comment to pass arbitrary or predefined notes:
Specify any additional patch prerequisites for cherry picking:
Cc: <[email protected]> # 3.3.x: a1f84a3: sched: Check for idle
Cc: <[email protected]> # 3.3.x: 1b9508f: sched: Rate-limit newidle
Cc: <[email protected]> # 3.3.x: fd21073: sched: Fix affinity logic
Cc: <[email protected]> # 3.3.x
Signed-off-by: Ingo Molnar <[email protected]>
The tag sequence has the meaning of:
git cherry-pick a1f84a3
git cherry-pick 1b9508f
git cherry-pick fd21073
git cherry-pick <this commit>
My tools don't look at Depends-on: and I don't think that Greg's tools do that
either.
--
Thanks,
Sasha
