On Mon, Jan 19, 2026 at 12:26 PM Danilo Krummrich <[email protected]> wrote: > > On Mon Jan 19, 2026 at 11:40 AM CET, Bartosz Golaszewski wrote: > > +/** > > + * of_machine_get_compatible - Get the compatible string of this machine > > + * @compatible: address at which the compatible string will be stored > > + * > > + * Returns: > > + * 0 on success, negative error number on failure. > > + */ > > +int of_machine_get_compatible(const char **compatible) > > I think the name of this function is not ideal. 'get' usually indicates that a > reference count will be taken, but this is not the case here. > > I'm also not sure about the machine prefix. If we really want this helper I'd > suggest something along the lines of e.g. of_root_read_compatible(). >
Makes sense for the "read" part but I'm not sure about the "root" bit. We already have a whole set of "of_machine_" interfaces, like of_machine_is_compatible(). How about of_machine_read_compatible()? Bartosz
