Hi Bartosz,
On Mon, 19 Jan 2026 at 11:40, Bartosz Golaszewski
<[email protected]> wrote:
> Don't access of_root directly as it reduces the build test coverage for
> this driver with COMPILE_TEST=y and OF=n. Use existing helper functions
> to retrieve the relevant information.
>
> Suggested-by: Rob Herring <[email protected]>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
Thanks for your patch!
> --- a/drivers/soc/renesas/renesas-soc.c
> +++ b/drivers/soc/renesas/renesas-soc.c
> @@ -6,6 +6,7 @@
> */
>
> #include <linux/bitfield.h>
> +#include <linux/cleanup.h>
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> @@ -468,7 +469,11 @@ static int __init renesas_soc_init(void)
> const char *soc_id;
> int ret;
>
> - match = of_match_node(renesas_socs, of_root);
> + struct device_node *root __free(device_node) =
> of_find_node_by_path("/");
> + if (!root)
> + return -ENOENT;
> +
> + match = of_match_node(renesas_socs, root);
I am not so fond of these of_find_node_by_path("/") + something replacements.
What about adding an of_match_root() helper?
However, in the previous patch you used a different strategy:
- if (!of_match_node(imx8_soc_match, of_root))
+ if (!of_machine_device_match(imx8_soc_match))
> if (!match)
> return -ENODEV;
>
>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
