On Mon, Mar 02, 2026 at 09:18:45AM +0100, David Hildenbrand (Arm) wrote: > On 2/28/26 13:38, Alice Ryhl wrote: > > On Fri, Feb 27, 2026 at 09:08:33PM +0100, David Hildenbrand (Arm) wrote: > >> Nobody except memory.c should really set that parameter to non-NULL. So > >> let's just drop it and make unmap_mapping_range_vma() use > >> zap_page_range_single_batched() instead. > >> > >> Signed-off-by: David Hildenbrand (Arm) <[email protected]> > > > >> diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs > >> index da21d65ccd20..b8e59e4420f3 100644 > >> --- a/rust/kernel/mm/virt.rs > >> +++ b/rust/kernel/mm/virt.rs > >> @@ -124,7 +124,7 @@ pub fn zap_page_range_single(&self, address: usize, > >> size: usize) { > >> // sufficient for this method call. This method has no > >> requirements on the vma flags. The > >> // address range is checked to be within the vma. > >> unsafe { > >> - bindings::zap_page_range_single(self.as_ptr(), address, size, > >> core::ptr::null_mut()) > >> + bindings::zap_page_range_single(self.as_ptr(), address, size) > >> }; > > > > Please run rustfmt on Rust changes. Here, rustfmt leads to this being > > formatted on a single line: > > Having to run tooling I don't even have installed when removing a single > function parameter; did not expect that :)
Well, rustfmt comes with the compiler, and it would be ideal to build test changes before sending them :) But no worries, I took care of testing it. Thanks for taking the time to update the Rust code as well. Documentation/rust/quick-start.rst has details for most distros. Alice
