On Sun, Mar 08, 2026 at 11:15:40PM +0100, Jori Koolstra wrote: > > > Op 08-03-2026 17:19 CET schreef Greg KH <[email protected]>: > > > > > > On Sun, Mar 08, 2026 at 01:39:12PM +0100, Jori Koolstra wrote: > > > diff --git a/arch/powerpc/platforms/powernv/vas-window.c > > > b/arch/powerpc/platforms/powernv/vas-window.c > > > index 9f093176b8db..34403582c895 100644 > > > --- a/arch/powerpc/platforms/powernv/vas-window.c > > > +++ b/arch/powerpc/platforms/powernv/vas-window.c > > > @@ -1459,7 +1459,6 @@ static const struct vas_user_win_ops vops = { > > > int vas_register_api_powernv(struct module *mod, enum vas_cop_type > > > cop_type, > > > const char *name) > > > { > > > - > > > return vas_register_coproc_api(mod, cop_type, name, &vops); > > > } > > > EXPORT_SYMBOL_GPL(vas_register_api_powernv); > > > > > > > This change wasn't needed here :( > > > > thanks, > > > > greg k-h > > My bad, I meant to copy this here instead of at the top of me last email: > > Now checkpatch complains that: > > CHECK: Blank lines aren't necessary after an open brace '{'
That's true, but don't mix patches together, and usually, for code outside of drivers/staging/ don't worry about checkpatch issues. > So the rule is: don't touch white space unless you absolutely have to? > > That is good to know to prevent silly v2's. I know that non-functional > changes are frowned upon; but you also shouldn't sneak in a white space > fixes? Exactly, don't sneak in anything :) thanks, greg k-h
