On Fri, 2008-10-10 at 18:43 +0400, Anton Vorontsov wrote: > The helper is factored out of of_get_gpio(). Will be used by the QE > pin multiplexing functions (they need to parse the gpios = <> too). > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > ---
> + while (list < list_end) { > + const u32 *cells; > + const phandle *phandle; > + > + phandle = list; > + args = list + 1; > + > + /* one cell hole in the list = <>; */ > + if (!*phandle) { > + list++; > + goto next; > + } Allright. I'll merge it. It might have been nicer to write here phandle = list++; args = list; if (!*phandle) goto next; .../... list += *cells; But it's not big deal, I'll merge it as-is and if you feel like it you can aways submit a cleanup later. In fact you can even completely drop "args" I think. Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev