Thanks Gautam catching this and proposing this patch. Minor review comments below:
Gautam Menghani <[email protected]> writes: > From: Gautam Menghani <[email protected]> > > The macro kvm_trace_symbol_exit is used for providing the mappings > for the trap vectors and their names. Add mapping for H_FAC_UNAVAIL so that > trap reason is displayed as string instead of a vector number when using > the kvm_guest_exit tracepoint. > > Signed-off-by: Gautam Menghani <[email protected]> > --- > v2: > 1. Remove the trailing comma after last element > > arch/powerpc/kvm/trace_book3s.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/trace_book3s.h b/arch/powerpc/kvm/trace_book3s.h > index 9260ddbd557f..5d272c115331 100644 > --- a/arch/powerpc/kvm/trace_book3s.h > +++ b/arch/powerpc/kvm/trace_book3s.h > @@ -28,6 +28,7 @@ > {0xea0, "H_VIRT"}, \ > {0xf00, "PERFMON"}, \ > {0xf20, "ALTIVEC"}, \ > - {0xf40, "VSX"} > + {0xf40, "VSX"}, \ > + {0xf80, "H_FAC_UNAVAIL"} Also add trap of 0x000 indicating "RETURN_TO_HOST" Also sychronize the contents of the proposed changes for this header with the libtraceevent header file tools/perf/util/kvm-stat-arch/book3s_hv_exits.h > > #endif > -- > 2.52.0 > > With above minor fixes done, feel free to add: Reviewed-by: Vaibhav Jain (IBM) <[email protected]> -- Cheers ~ Vaibhav
