On Wed, Mar 4, 2026 at 3:07 AM Bartosz Golaszewski <[email protected]> wrote: > > @@ -557,7 +549,6 @@ config PINCTRL_ST > config PINCTRL_STMFX > tristate "STMicroelectronics STMFX GPIO expander pinctrl driver" > depends on I2C > - depends on OF_GPIO > depends on HAS_IOMEM > select GENERIC_PINCONF > select GPIOLIB_IRQCHIP
This change causes the following warning on builds: WARNING: unmet direct dependencies detected for MFD_STMFX Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n] Selected by [m]: - PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y] WARNING: unmet direct dependencies detected for MFD_STMFX Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n] Selected by [m]: - PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y] I believe the proper fix is to have PINCTRL_STMFX depend on CONFIG_OF, since this driver actually does depend on CONFIG_OF. The warning comes because if CONFIG_OF is disabled, PINCTRL_STMFX can still be enabled, but in doing so it selects MFD_STMFX which does depend on CONFIG_OF. Adding "depends on OF" to "config PINCTRL_STMFX" seems to fix the problem, but I'm not familiar with this driver so I'm not sure this is the right fix. I'll post a patch.
