On Mon, May 25, 2026 at 7:35 AM Petr Pavlu <[email protected]> wrote: > > On 5/21/26 3:33 PM, Kees Cook wrote: > > Using Coccinelle, rewrite every struct kernel_param_ops initializer that > > sets .get into a DEFINE_KERNEL_PARAM_OPS-family macro invocation, > > for example: > > > > @@ > > declarer name DEFINE_KERNEL_PARAM_OPS; > > identifier OPS; > > expression SET, GET; > > @@ > > - const struct kernel_param_ops OPS = { > > - .set = SET, > > - .get = GET, > > - }; > > + DEFINE_KERNEL_PARAM_OPS(OPS, SET, GET); > > > > Using the macro for initialization means future changes can manipulate > > the struct layout and callback prototypes without having to change every > > initializer. > > Nit: For consistency, I suggest also converting the few remaining > kernel_param_ops instances that specify only .set and no .get, such as > simdisk_param_ops_filename. > > -- > Thanks, > Petr
for the dynamic-debug changes Reviewed-by: Jim Cromie <[email protected]>
