On Tue, Jul 07, 2026 at 09:06:44PM +0200, Thomas Gleixner wrote: > The return value of that function is boolean and tells the caller whether > to permit the syscall processing or not. > > Rename the function so the purpose is clear and make the return type bool. > > Signed-off-by: Thomas Gleixner <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Oleg Nesterov <[email protected]> > Cc: Richard Henderson <[email protected]> > Cc: Vineet Gupta <[email protected]> > Cc: Russell King <[email protected]> > Cc: Catalin Marinas <[email protected]> > Cc: Will Deacon <[email protected]> > Cc: Guo Ren <[email protected]> > Cc: Brian Cain <[email protected]> > Cc: Geert Uytterhoeven <[email protected]> > Cc: Michal Simek <[email protected]> > Cc: Thomas Bogendoerfer <[email protected]> > Cc: Dinh Nguyen <[email protected]> > Cc: Helge Deller <[email protected]> > Cc: Yoshinori Sato <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: Andreas Larsson <[email protected]> > Cc: Chris Zankel <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > arch/alpha/kernel/ptrace.c | 2 +- > arch/arc/kernel/ptrace.c | 2 +- > arch/arm/kernel/ptrace.c | 2 +- > arch/arm64/kernel/ptrace.c | 2 +- > arch/csky/kernel/ptrace.c | 2 +- > arch/hexagon/kernel/traps.c | 2 +- > arch/m68k/kernel/ptrace.c | 2 +- > arch/microblaze/kernel/ptrace.c | 2 +- > arch/mips/kernel/ptrace.c | 2 +- > arch/nios2/kernel/ptrace.c | 2 +- > arch/openrisc/kernel/ptrace.c | 2 +- > arch/parisc/kernel/ptrace.c | 10 ++++------ > arch/sh/kernel/ptrace_32.c | 2 +- > arch/sparc/kernel/ptrace_32.c | 2 +- > arch/sparc/kernel/ptrace_64.c | 2 +- > arch/um/kernel/ptrace.c | 2 +- > arch/xtensa/kernel/ptrace.c | 2 +- > include/asm-generic/syscall.h | 4 ++-- > include/linux/entry-common.h | 25 ++++++++++++------------- > include/linux/ptrace.h | 13 ++++++------- > 20 files changed, 40 insertions(+), 44 deletions(-) > [...] > --- a/arch/parisc/kernel/ptrace.c > +++ b/arch/parisc/kernel/ptrace.c > @@ -326,7 +326,7 @@ long compat_arch_ptrace(struct task_stru > long do_syscall_trace_enter(struct pt_regs *regs) > { > if (test_thread_flag(TIF_SYSCALL_TRACE)) { > - int rc = ptrace_report_syscall_entry(regs); > + bool permit = ptrace_report_syscall_permit_entry(regs); > > /* > * As tracesys_next does not set %r28 to -ENOSYS > @@ -334,12 +334,10 @@ long do_syscall_trace_enter(struct pt_re > */ > regs->gr[28] = -ENOSYS; > > - if (rc) { > + if (!permit) { > /* > - * A nonzero return code from > - * ptrace_report_syscall_entry() tells us > - * to prevent the syscall execution. Skip > - * the syscall call and the syscall restart handling. > + * Skip the syscall call and the syscall restart > + * handling. Hey Thomas,
This comment `syscall call` sounds a bit weird. Apart from this, Everything looks good. Regards, Mukesh Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <[email protected]>
