On Mon, Jul 13, 2026 at 06:08:56PM +0530, Ritesh Harjani wrote:
> Thorsten Blum <[email protected]> writes:
>
> > If lv1_put_iopte() fails in dma_ioc0_map_pages(), the error path
> > decrements iopage but keeps using the failed mapping's offset. As a
> > result, it repeatedly tries to invalidate the failed IOPTE slot and
> > leaves the already installed IOPTEs valid.
> >
> > Recompute offset and invalidate the installed IOPTEs instead.
> >
>
> Nice catch! I wonder how did you catch this?
> Do you have ps3 console where you somehow ran into this ;)
> Or was it a manual inspection?
I do have a PS3 somewhere, but I stumbled upon this while reading and
trying to understand the code.
> I wonder whether PS3 consoles are still being used?
Not sure.
> > Fixes: 6bb5cf102541 ("[POWERPC] PS3: System-bus rework")
>
> Looks like this was from 2007.
>
> However, the change looks good to me. So:
> Reviewed-by: Ritesh Harjani (IBM) <[email protected]>
Thanks,
Thorsten
