On Mon, Jul 20, 2026 at 09:43:11AM +0800, [email protected] wrote: > From: Wei Fang <[email protected]> > > The function enetc4_set_default_si_vlan_promisc() is only called once, > from enetc4_configure_port_si(). Open-code the loop at the call site > and remove the single-use wrapper. > > Signed-off-by: Wei Fang <[email protected]> > --- > drivers/net/ethernet/freescale/enetc/enetc4_pf.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c > b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c > index 859b02f5170a..505e4abf6c37 100644 > --- a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c > +++ b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c > @@ -307,17 +307,6 @@ static void enetc4_pf_set_si_vlan_promisc(struct > enetc_hw *hw, int si, bool en) > enetc_port_wr(hw, ENETC4_PSIPVMR, val); > } > > -static void enetc4_set_default_si_vlan_promisc(struct enetc_pf *pf) > -{ > - struct enetc_hw *hw = &pf->si->hw; > - int num_si = pf->caps.num_vsi + 1; > - int i; > - > - /* enforce VLAN promiscuous mode for all SIs */ > - for (i = 0; i < num_si; i++) > - enetc4_pf_set_si_vlan_promisc(hw, i, true); > -} > - > /* Allocate the number of MSI-X vectors for per SI. */ > static void enetc4_set_si_msix_num(struct enetc_pf *pf) > { > @@ -361,7 +350,9 @@ static void enetc4_configure_port_si(struct enetc_pf *pf) > /* Outer VLAN tag will be used for VLAN filtering */ > enetc_port_wr(hw, ENETC4_PSIVLANFMR, PSIVLANFMR_VS); > > - enetc4_set_default_si_vlan_promisc(pf); > + /* Enforce VLAN promiscuous mode for all SIs */ > + for (int i = 0; i < pf->caps.num_vsi + 1; i++) > + enetc4_pf_set_si_vlan_promisc(hw, i, true); > > /* Disable SI MAC multicast & unicast promiscuous */ > enetc_port_wr(hw, ENETC4_PSIPMMR, 0);
Reviewed-by: Joe Damato <[email protected]>
