alloc_skb() with the __GFP_NOFAIL flag will never return NULL,
so the subsequent NULL checks and error handling are unreachable
dead code. Remove them.

Signed-off-by: Gou Hao <[email protected]>
---
 drivers/infiniband/hw/cxgb4/mem.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb4/mem.c 
b/drivers/infiniband/hw/cxgb4/mem.c
index cd1b010141984..08631de17c0a3 100644
--- a/drivers/infiniband/hw/cxgb4/mem.c
+++ b/drivers/infiniband/hw/cxgb4/mem.c
@@ -74,11 +74,8 @@ static int _c4iw_write_mem_dma_aligned(struct c4iw_rdev 
*rdev, u32 addr,
                c4iw_init_wr_wait(wr_waitp);
        wr_len = roundup(sizeof(*req) + sizeof(*sgl), 16);
 
-       if (!skb) {
+       if (!skb)
                skb = alloc_skb(wr_len, GFP_KERNEL | __GFP_NOFAIL);
-               if (!skb)
-                       return -ENOMEM;
-       }
        set_wr_txq(skb, CPL_PRIORITY_CONTROL, 0);
 
        req = __skb_put_zero(skb, wr_len);
@@ -134,11 +131,8 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rdev, 
u32 addr, u32 len,
                                         roundup(copy_len, T4_ULPTX_MIN_IO),
                                 16);
 
-               if (!skb) {
+               if (!skb)
                        skb = alloc_skb(wr_len, GFP_KERNEL | __GFP_NOFAIL);
-                       if (!skb)
-                               return -ENOMEM;
-               }
                set_wr_txq(skb, CPL_PRIORITY_CONTROL, 0);
 
                req = __skb_put_zero(skb, wr_len);
-- 
2.20.1


Reply via email to