On 8/13/26 08:03, Anshuman Khandual wrote: > On Wed, Aug 12, 2026 at 01:33:14PM +0200, David Hildenbrand (Arm) wrote: >> On 8/11/26 06:21, Anshuman Khandual wrote: >>> pxd_ERROR() has been used in generic mm just to print the page table entry >>> in pxd_clear_bad() before clearing those out with pxd_clear() later. These >>> pxd_ERROR() macros have been provided by all platforms which basically did >>> the same thing. >>> >>> Make pxd_clear_bad() use recently added ptval_to_str() instead for printing >>> page table entries thus completely dropping dependency on platform provided >>> pxd_ERROR() macros which can then be dropped off. First move all required >>> helpers in core MM into a header file which could then be used else where. >>> >> >> It might make sense to split this patch further up to ease review: >> >> Patch 1) provide ptval_to_str() a header. >> >> Patch 2) Stop using pxd_ERROR() and friends in common code, converting to >> pteval_to_str() >> >> Patch 3) Remove now unused pxd_ERROR() and friends from arch code. > > Sure but the intiial platform changes which now use ptval_to_str() as well > will probably come after the Patch (2) but before the Patch (3).
Exactly :) -- Cheers, David
