From: Wei Fang <[email protected]> The ingress port filtering lookup function involves performing a lookup against the ingress port filter table (IPFT). If the frame matches an entry, subsequent frame processing functions will perform corresponding operations based on the parameters specified in that entry. If no entry matches the frame, the frame is allowed in, and passed to the next frame processing function.
In the future, the IPFT will be used to filter PTP frames and support tc flower. Tracking in software whether any IPFT entry exists for a port in order to decide whether to enable the ingress port filtering lookup would increase code complexity unnecessarily. Since enabling the lookup when the IPFT is empty has no effect on RX frames, enable the ingress port filtering lookup unconditionally during driver initialization to simplify code logic. The only concern is that when deleting an IPFT entry fails, the hardware will continue filtering RX frames based on that entry. However, we have no choice. We cannot disable ingress port filter lookup because this would deactivate other IPFT entries, which is obviously not what we want. Moreover, deletion failures are almost impossible under normal circumstances, and we don't need to be bothered by this minor issue. Signed-off-by: Wei Fang <[email protected]> --- drivers/net/dsa/netc/netc_main.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/netc/netc_main.c b/drivers/net/dsa/netc/netc_main.c index 2171c83f3640..ae3dc487f5f8 100644 --- a/drivers/net/dsa/netc/netc_main.c +++ b/drivers/net/dsa/netc/netc_main.c @@ -555,6 +555,12 @@ static void netc_port_fixed_config(struct netc_port *np) netc_port_rmw(np, NETC_PCR, PCR_L2DOSE | PCR_L3DOSE, PCR_L2DOSE | PCR_L3DOSE); + /* Enable ingress port filter table lookup, if no match is found, + * the frame is allowed and passed to the next frame processing + * function. + */ + netc_port_wr(np, NETC_PIPFCR, PIPFCR_EN); + /* Set the quanta value of TX PAUSE frame */ netc_mac_port_wr(np, NETC_PM_PAUSE_QUANTA(0), NETC_PAUSE_QUANTA); @@ -1761,8 +1767,6 @@ static int netc_port_add_host_flood_rule(struct netc_port *np, np->uc = uc; np->mc = mc; np->ipft_hf_eid = host_flood->entry_id; - /* Enable ingress port filter table lookup */ - netc_port_wr(np, NETC_PIPFCR, PIPFCR_EN); free_host_flood: kfree(host_flood); @@ -1786,7 +1790,6 @@ static int netc_port_remove_host_flood(struct netc_port *np) np->ipft_hf_eid = NTMP_NULL_ENTRY_ID; np->uc = false; np->mc = false; - netc_port_wr(np, NETC_PIPFCR, 0); return 0; } -- 2.34.1
