On 2026/09/01 03:26 PM, [email protected] wrote: > From 80fd05e6d156d5a90d4908f2498bf6cc7acbdefd Mon Sep 17 00:00:00 2001 > From: Bui Nguyen Nhu Quynh <[email protected]> > Date: Tue, 1 Sep 2026 19:39:49 +0700 > Subject: [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info > > The kvmppc_gsm_refresh_info() function incorrectly checks for the > presence of the fill_info callback instead of refresh_info. > > This can lead to: > - NULL pointer dereference if refresh_info is NULL but fill_info is present > - EINVAL return if refresh_info is present but fill_info is NULL > > Fix this by checking the correct callback. > > Fixes: 6ccbbc33f06ad ("KVM: PPC: Add helper library for Guest State Buffers") > Signed-off-by: Bui Nguyen Nhu Quynh <[email protected]> > --- > arch/powerpc/kvm/guest-state-buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/guest-state-buffer.c > b/arch/powerpc/kvm/guest-state-buffer.c > index 42843eca6727..aeb586ba4523 100644 > --- a/arch/powerpc/kvm/guest-state-buffer.c > +++ b/arch/powerpc/kvm/guest-state-buffer.c > @@ -598,7 +598,7 @@ EXPORT_SYMBOL_GPL(kvmppc_gsm_fill_info); > int kvmppc_gsm_refresh_info(struct kvmppc_gs_msg *gsm, > struct kvmppc_gs_buff *gsb) > { > - if (!gsm->ops->fill_info) > + if (!gsm->ops->refresh_info) > return -EINVAL;
Thanks for catching this. The patch appears corrupted by your email client (whitespace mangling / quoted-printable encoding). ❯ git apply ./20260901_nhuquynh_kvm_ppc_fix_callback_check_in_kvmppc_gsm_refresh_info.mbx error: corrupt patch at line 30 Please consider configuring and using git send-email to submit v2. Thanks, Amit > > return gsm->ops->refresh_info(gsm, gsb); > -- > 2.54.0
