If the xive_native_configure_queue() call fails, the qpage allocated is
not freed, which results in wasted memory. Fix this by freeing the qpage
in the error path.

Fixes: 5af50993850a ("KVM: PPC: Book3S HV: Native usage of the XIVE interrupt 
controller")
Signed-off-by: Gautam Menghani <[email protected]>
---
 arch/powerpc/kvm/book3s_xive.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/book3s_xive.c b/arch/powerpc/kvm/book3s_xive.c
index 1d67237783b7..6f8648d9302b 100644
--- a/arch/powerpc/kvm/book3s_xive.c
+++ b/arch/powerpc/kvm/book3s_xive.c
@@ -961,9 +961,11 @@ static int xive_provision_queue(struct kvm_vcpu *vcpu, u8 
prio)
         */
        rc = xive_native_configure_queue(xc->vp_id, q, prio, qpage,
                                         xive->q_order, true);
-       if (rc)
+       if (rc) {
+               free_pages((unsigned long)qpage, xive->q_page_order);
                pr_err("Failed to configure queue %d for VCPU %d\n",
                       prio, xc->server_num);
+       }
        return rc;
 }
 
-- 
2.50.1 (Apple Git-155)


Reply via email to