Hi Morimoto-san, Thank you for your confirmation.
> > For MSIOF, I noticed that snd_dmaengine_pcm_open() already calls > > snd_pcm_hw_constraint_integer() for SNDRV_PCM_HW_PARAM_PERIODS, > > so the call in msiof_open() seems redundant. > > > > Since the first call succeeds, the second call should return 0. > > Would removing the redundant call be acceptable? > > Nice cache, yes please. > For rz-ssi: in DMA mode, the driver registers the generic dmaengine PCM component, whose .open callback already applies the integer PERIODS constraint via snd_dmaengine_pcm_open(). Could we drop rz_ssi_pcm_open_dma() instead, and keep the return value fix only for rz_ssi_pcm_open_pio()? Best regards, Phuc
