On 10/16/26 10:04 PM, Frank Li wrote:

[...]

+int enetc_mdio_update_mdc_div(struct mii_bus *bus)
+{
+       struct enetc_mdio_priv *mdio_priv = bus->priv;
+       struct device *dev = bus->parent;
+       struct clk *enet_clk;
+       u32 div, mdc_freq;
+
+       if (device_property_read_u32(dev, "clock-frequency", &mdc_freq))
+               return 0;
+
+       enet_clk = devm_clk_get(dev, NULL);
+       if (IS_ERR(enet_clk))
+               return dev_err_probe(dev, PTR_ERR(enet_clk),
+                                    "Input clock unknown, not changing MDC 
frequency\n");

binding said clock is optional. If return failure here, it will block
existing dts, which have not clock property.

should be devm_clk_get_optional()?
Existing DTs are fine, since they don't define clock-frequency property. And whoever wants to define clock-frequency property, they also must provide clock property.

Reply via email to