A retry allocates new elf headers and overwrites image->elf_headers,
leaking the previous buffer.  Free it before assigning.

Cc: Huacai Chen <[email protected]>
Cc: WANG Xuerui <[email protected]>
Cc: Youling Tang <[email protected]>
Cc: Mike Rapoport (Microsoft) <[email protected]>
Cc: Sourabh Jain <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: [email protected]
Link: 
https://sashiko.dev/#/patchset/20260729031235.2840255-1-ruanjinjie%40huawei.com
Fixes: 55d990f0084c ("LoongArch: Add EFI binary support for kexec_file")
Signed-off-by: Jinjie Ruan <[email protected]>
---
 arch/loongarch/kernel/machine_kexec_file.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/loongarch/kernel/machine_kexec_file.c 
b/arch/loongarch/kernel/machine_kexec_file.c
index 62a5be102065..3beb6977ecc6 100644
--- a/arch/loongarch/kernel/machine_kexec_file.c
+++ b/arch/loongarch/kernel/machine_kexec_file.c
@@ -166,6 +166,10 @@ int load_other_segments(struct kimage *image,
                        vfree(headers);
                        goto out_err;
                }
+
+               if (unlikely(image->elf_headers))
+                       vfree(image->elf_headers);
+
                image->elf_headers = headers;
                image->elf_load_addr = kbuf.mem;
                image->elf_headers_sz = headers_sz;
-- 
2.34.1


Reply via email to