On 28/10/2026 20:40, Lefteris Koutrakis wrote: > This commit adds initial device tree support for the WatchGuard Firebox T30
Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94 Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > board and enables building firebox-t30.dtb under CONFIG_MPC85xx_RDB in > arch/powerpc/boot/dts/fsl/Makefile. It also documents the watchguard vendor > prefix in vendor-prefixes.yaml. > > Signed-off-by: Lefteris Koutrakis <[email protected]> > --- > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > arch/powerpc/boot/dts/fsl/Makefile | 1 + > arch/powerpc/boot/dts/fsl/firebox-t30.dts | 386 ++++++++++++++++++ > .../arch/powerpc/boot/dts/firebox-t30.dts | 386 ++++++++++++++++++ > 4 files changed, 775 insertions(+) > create mode 100644 Documentation/devicetree/bindings/vendor-prefixes.yaml > create mode 100644 arch/powerpc/boot/dts/fsl/Makefile > create mode 100644 arch/powerpc/boot/dts/fsl/firebox-t30.dts > create mode 100644 > target/linux/mpc85xx/files/arch/powerpc/boot/dts/firebox-t30.dts > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml > b/Documentation/devicetree/bindings/vendor-prefixes.yaml > new file mode 100644 > index 0000000..c78a53f > --- /dev/null Not existing? You are sending some random changes to us. Please slow down, read the docs how to use Git and how to generate patches. Documentation/process (including submitting patches) will be helpful. > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -0,0 +1,2 @@ > + "watchguard,": > + description: WatchGuard Technologies, Inc. > diff --git a/arch/powerpc/boot/dts/fsl/Makefile > b/arch/powerpc/boot/dts/fsl/Makefile > new file mode 100644 > index 0000000..60caf36 Best regards, Krzysztof
