Gautam Menghani <[email protected]> writes: > In kvmppc_xive_connect_vcpu(), if any failures are encountered, the > control flow jumps to the 'bail' label where kvmppc_xive_cleanup_vcpu() > is called. This cleanup function exits prematurely since > vcpu->arch.irq_type is set to KVMPPC_IRQ_DEFAULT at this point. This ends > up resulting in wasted memory. > > Fix this by setting irq_type to KVMPPC_IRQ_XICS before vcpu configuration > starts. This makes XICS initialization symmetrical to XIVE > initialization done in kvmppc_xive_native_connect_vcpu(). > > Fixes: 5af50993850a ("KVM: PPC: Book3S HV: Native usage of the XIVE interrupt > controller") > Cc: [email protected] # 4.12+ > Signed-off-by: Gautam Menghani <[email protected]>
Mainly fixes the error handling / cleanup routine in kvmppc_xive_connect_cpu(). The fix looks good to me, feel free to add: Reviewed-by: Ritesh Harjani (IBM) <[email protected]>
