On 11/3/26 9:03 AM, Thorsten Blum wrote:
> The %pa format specifier already includes the 0x prefix. Remove the
> redundant prefixes to avoid printing 0x0x.
>
> Fixes: 7b69600d4da0 ("powerpc/wii: fix resource printk format warnings")
> Signed-off-by: Thorsten Blum <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
There are other cases of this elsewhere in the kernel sources.
Are you addressing those also?
Thanks.
> ---
> arch/powerpc/platforms/embedded6xx/flipper-pic.c | 2 +-
> arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 2 +-
> arch/powerpc/platforms/embedded6xx/wii.c | 6 ++----
> 3 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/arch/powerpc/platforms/embedded6xx/flipper-pic.c
> b/arch/powerpc/platforms/embedded6xx/flipper-pic.c
> index 91a8f0a7086e..e9c84793cc4d 100644
> --- a/arch/powerpc/platforms/embedded6xx/flipper-pic.c
> +++ b/arch/powerpc/platforms/embedded6xx/flipper-pic.c
> @@ -145,7 +145,7 @@ static struct irq_domain * __init flipper_pic_init(struct
> device_node *np)
> }
> io_base = ioremap(res.start, resource_size(&res));
>
> - pr_info("controller at 0x%pa mapped to 0x%p\n", &res.start, io_base);
> + pr_info("controller at %pa mapped to 0x%p\n", &res.start, io_base);
>
> __flipper_quiesce(io_base);
>
> diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> index 1522a8bece29..a1bdb83fe51f 100644
> --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> @@ -171,7 +171,7 @@ static struct irq_domain *__init hlwd_pic_init(struct
> device_node *np)
> return NULL;
> }
>
> - pr_info("controller at 0x%pa mapped to 0x%p\n", &res.start, io_base);
> + pr_info("controller at %pa mapped to 0x%p\n", &res.start, io_base);
>
> __hlwd_quiesce(io_base);
>
> diff --git a/arch/powerpc/platforms/embedded6xx/wii.c
> b/arch/powerpc/platforms/embedded6xx/wii.c
> index e7eec328f121..928d082abf56 100644
> --- a/arch/powerpc/platforms/embedded6xx/wii.c
> +++ b/arch/powerpc/platforms/embedded6xx/wii.c
> @@ -73,10 +73,8 @@ static void __iomem *__init wii_ioremap_hw_regs(char
> *name, char *compatible)
> }
>
> hw_regs = ioremap(res.start, resource_size(&res));
> - if (hw_regs) {
> - pr_info("%s at 0x%pa mapped to 0x%p\n", name,
> - &res.start, hw_regs);
> - }
> + if (hw_regs)
> + pr_info("%s at %pa mapped to 0x%p\n", name, &res.start,
> hw_regs);
>
> out_put:
> of_node_put(np);
--
~Randy
