On Tue, 3 Nov 2026, Andy Shevchenko wrote:
> > +static unsigned long sccnxp_handle_events(struct sccnxp_port *s)
> > {
>
> > - int i;
> > + unsigned int i;
>
> This change seems unrelated to the patch. Again, slow down and READ what AI
> produces before sending, please!
Indeed. FWIW I've thrown v8 at hardware I look after, that is:
drivers/tty/serial/dz.c | 9 ++--
drivers/tty/serial/sb1250-duart.c | 25 ++++++----
drivers/tty/serial/zs.c | 94 ++++++++++++++++++++++++++++----------
drivers/tty/serial/zs.h | 3 ++
and that has caused no observable regressions in my simple verification as
direct terminal lines, both in the line mode and with ncurses.
I have no leased-line modem hardware to put this under stress with all
the signalling; I could see, and probably should, whether I can set up a
SLIP connection with a direct serial link and see how it performs, but
it'd take me more time than I can afford right now, especially as I'm
locally short of one PSU for the systems in question that is waiting for
parts to arrive for repair, and swapping the one working unit between
systems is quite involving (ones in the lab won't run SLIP owing to the
firmware limitation of the console servers they're wired to).
But I didn't have a chance to reply before v9 has been posted with more
updates, so I'll wait for things to settle before reviewing the changes in
detail.
Please consider this a NAK for the drivers listed above until the final
version of the patch has been posted and I've had a chance to verify it.
Maciej
