On Thu, Nov 05, 2026 at 08:13:12PM +0530, Srish Srinivasan wrote:
> plpks_gen_wrapping_key() returns a negative errno when default wrapping key
> generation fails. However, trusted_pkwm_init() returns -EINVAL for all such
> failures, discarding the original error.
>
> Propagate the error returned by plpks_gen_wrapping_key() unchanged.
>
> Fixes: c99fcb0d735b ("keys/trusted_keys: establish PKWM as a trusted source")
> Cc: [email protected] # 7.0
> Signed-off-by: Srish Srinivasan <[email protected]>
> Tested-by: R Nageswara Sastry <[email protected]>
Nit: I'd put the SOB as last.
> ---
> security/keys/trusted-keys/trusted_pkwm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/keys/trusted-keys/trusted_pkwm.c
> b/security/keys/trusted-keys/trusted_pkwm.c
> index bf42c6679245..422f752598e1 100644
> --- a/security/keys/trusted-keys/trusted_pkwm.c
> +++ b/security/keys/trusted-keys/trusted_pkwm.c
> @@ -170,7 +170,7 @@ static int trusted_pkwm_init(void)
> ret = plpks_gen_wrapping_key();
> if (ret) {
> pr_err("Failed to generate default wrapping key\n");
> - return -EINVAL;
> + return ret;
> }
>
> return register_key_type(&key_type_trusted);
> --
> 2.52.0
>
Reviewed-by: Jarkko Sakkinen <[email protected]>
Br, Jarkko
