On Tue, 17 Nov 2026 12:10:16 +0100
Pierre Gondois <[email protected]> wrote:

> aer_recover_queue() now copies the input aer_regs instead of
> storing a pointer to the struct. Use a local variable to pass
> aer_regs in ghes_handle_aer() and remove the memory allocation
> introduced by:
> commit e2abc47a5a1a ("ACPI: APEI: Fix AER info corruption when error
> status data has multiple sections")
> 
> No functional change intended.
> 
> Signed-off-by: Pierre Gondois <[email protected]>
Just one trivial thing.

I didn't bother figuring out impact of the change discussed on previous
patch on this one, so no tags for this version.

> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 57406494ec1f7..d7ef84e3b988e 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -32,7 +32,6 @@
>  #include <linux/slab.h>
>  #include <linux/vmcore_info.h>
>  #include <acpi/apei.h>
> -#include <acpi/ghes.h>
>  #include <ras/ras_event.h>
>  
>  #include "../pci.h"
> @@ -1413,18 +1412,15 @@ static DECLARE_WORK(aer_recover_work, 
> aer_recover_work_func);
>   * @severity: AER_CORRECTABLE, AER_NONFATAL or AER_FATAL
>   * @aer_regs: snapshot of the device's AER Capability registers
>   *
> - * Queue an error record received from firmware through APEI GHES.  The
> - * record is processed later from a workqueue, which logs the error and,
> + * Queue an error record received from firmware. The record is processed
> + * later from a workqueue, which logs the error and,
>   * for uncorrectable errors, attempts recovery of the device.

Whilst noisier, you should probably still rewrap that last line.

>   *


Reply via email to