On Tue, 18 Nov 2008, Michael Ellerman wrote:
> On Mon, 2008-11-17 at 14:22 -0800, Trent Piepho wrote:
>> On Mon, 17 Nov 2008, Kumar Gala wrote:
>>> On Nov 17, 2008, at 3:58 PM, Trent Piepho wrote:
>>>
>>>> It's over a dozen lines of output and doesn't appear to provide any useful
>>>> information. Even after looking at the code, I'm in the dark about what
>>>> "score 299, offset 250" means.
>>>>
>>>> Signed-off-by: Trent Piepho <[EMAIL PROTECTED]>
>>>> ---
>>>> +++ b/arch/powerpc/kernel/smp-tbsync.c
>>>> @@ -113,7 +113,7 @@ void __devinit smp_generic_give_timebase(void)
>>>> {
>>>> int i, score, score2, old, min=0, max=5000, offset=1000;
>>>>
>>>> - printk("Synchronizing timebase\n");
>>>> + pr_info("Synchronizing timebase\n");
>>>
>>> I think its useful to leave this as a printk.
>>
>> #define pr_info(fmt, arg...) \
>> printk(KERN_INFO fmt, ##arg)
>>
>> Isn't printk with no level tag the same as KERN_INFO?
>
> Stuff like this should IMHO be printk(KERN_DEBUG ..)
>
> That way it will show up in the log as long as you boot with 'debug' on
> your command line, it doesn't require a kernel recompile to turn on. And
> at the same time it doesn't spam the boot log for a normal boot.
Originally my patched changed it to debug, but Kumar requested I keep it at
info level. The timebase sync code might hang or be slow, so it's nice to
give a status output before doing it. It seems just as good as most of the
info printks during boot.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
