On Dec 3, 2008, at 10:17 AM, Geert Uytterhoeven wrote:

On Wed, 3 Dec 2008, Kumar Gala wrote:
arch/powerpc/platforms/85xx/mpc85xx_mds.c: In function 'board_fixups': arch/powerpc/platforms/85xx/mpc85xx_mds.c:244: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'resource_size_t' arch/powerpc/platforms/85xx/mpc85xx_mds.c:250: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'

Signed-off-by: Kumar Gala <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/85xx/mpc85xx_mds.c |    4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/ powerpc/platforms/85xx/mpc85xx_mds.c
index 2494c51..915e8d3 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -241,13 +241,13 @@ static int __init board_fixups(void)
                mdio = of_find_compatible_node(NULL, NULL, compstrs[i]);

                of_address_to_resource(mdio, 0, &res);
-               snprintf(phy_id, BUS_ID_SIZE, "%x:%02x", res.start, 1);
+               snprintf(phy_id, BUS_ID_SIZE, "%llx:%02x", (u64)res.start, 1);
                                                           ^^^
unsigned long? u64 differs for 32-bit and 64-bit.

This is proper. This is a 32-bit only platform (and the format is long long).

Doh, if you would put the whole resource range there, you could use %pR ;-)

and if we had a %R ... :)

- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to