On Wed, Feb 04, 2009 at 12:00:52PM -0800, Mike Ditto wrote: > Timur Tabi wrote: > > However, it appears that this is not common behavior for I2C driver. In > > fact, only these six drivers ever call wait_event_interruptible_timeout():
> > i2c-cpm.c > I don't know about the others, but in i2c-cpm.c the use of interruptible > wait seems incorrect. Maybe it could be made correct, but as is, it > does not correctly clean up the hardware state or return a useful > value when interrupted by a signal. It's not clear what to do, anyway - This is exactly the problem for users that caused Timur to run into this - further up the stack we're trying to do cleanup that involves writing via I2C but the I2C writes error out due to the signal. > handling (one second delay in the unlikely worst case for i2c-cpm). Ditto for the Freescale PowerPC I2C driver. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
