On Wed, Apr 01, 2009 at 04:33:31PM -0500, Kumar Gala wrote: > The following commit breaks PPC builds with CONFIG_HIGHMEM=y > > commit f4112de6b679d84bd9b9681c7504be7bdfb7c7d5 > Author: Akinobu Mita <akinobu.m...@gmail.com> > Date: Tue Mar 31 15:23:25 2009 -0700 > > mm: introduce debug_kmap_atomic >
Thanks. But the definition of debug_kmap_atomic() needs to be outside of ifdef CONFIG_HIGHMEM. Because debug_kmap_atomic() is used without CONFIG_HIGHMEM by kmap_atomic_prot_pfn() in arch/x86/mm/iomap_32.c > --- a/include/linux/highmem.h > +++ b/include/linux/highmem.h > @@ -20,6 +20,19 @@ static inline void flush_kernel_dcache_page(struct page > *page) > #endif > > #ifdef CONFIG_HIGHMEM > +#include <asm/kmap_types.h> > + > +#if defined(CONFIG_DEBUG_HIGHMEM) && defined(CONFIG_TRACE_IRQFLAGS_SUPPORT) > + > +void debug_kmap_atomic(enum km_type type); > + > +#else > + > +static inline void debug_kmap_atomic(enum km_type type) > +{ > +} > + > +#endif > > #include <asm/highmem.h> > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev