On Thursday 02 April 2009, Harry Ciao wrote: > +#ifdef CONFIG_EDAC > +#define CPC925_MC_START 0xf8000000 > +#define CPC925_MC_END 0xf8ffffff /* sizeof 16MB */ > +/* Register a platform device for CPC925 memory controller */ > +static int __init maple_cpc925_edac_setup(void)
It's not good to have these encoded as magic numbers. Can't you find the addresses in the device tree? Maybe it's even possible to make this an of_platform_driver if you find a good node to bind to. Does the driver also work on a G5 Mac, or is it limited to the maple platform? Arnd <>< _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev