Bartlomiej Zolnierkiewicz writes: > mediabay shouldn't include <linux/ide.h> unconditionally so > remove the superfluous include from mediabay.c (<asm/mediabay.h> > will pull <linux/ide.h> in for CONFIG_BLK_DEV_IDE_PMAC=y).
I don't like relying on second-hand imports like that. I prefer the previous patch, that made mediabay depend on CONFIG_BLOCK. BTW, if including <linux/ide.h> causes an error when CONFIG_BLOCK=n, then there is a bug in <linux/ide.h>, IMO. Paul. _______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
