On Thu, 2009-05-14 at 19:13 +0530, K.Prasad wrote: > plain text document attachment (ppc64_prepare_code_01) > Prepare the PowerPC code for HW Breakpoint infrastructure patches by including > relevant constant definitions and function declarations.
Hi ! Some comments below... > +#define HBP_NUM 1 /* Number of physical HW breakpoint registers */ Can you use a more verbose constant ? reg.h is included everywhere so the risk of collision is high. > #define DABR_TRANSLATION (1UL << 2) > #define DABR_DATA_WRITE (1UL << 1) > #define DABR_DATA_READ (1UL << 0) > +#define DABR_DATA_RW (3UL << 0) Do you really need that ? It's just DABR_DATA_WRITE | DABR_DATA_READ :-) Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
