On Wed, 20 May 2009, Alexander Beregalov wrote: > Fix this build error: > drivers/built-in.o: In function `phy_state_machine': > drivers/net/phy/phy.c:893: undefined reference to 'netif_carrier_off' > drivers/net/phy/phy.c:854: undefined reference to 'netif_carrier_on' > > Signed-off-by: Alexander Beregalov <[email protected]> > --- > arch/powerpc/platforms/82xx/Kconfig | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/platforms/82xx/Kconfig > b/arch/powerpc/platforms/82xx/Kconfig > index 7c7df40..36a3e58 100644 > --- a/arch/powerpc/platforms/82xx/Kconfig > +++ b/arch/powerpc/platforms/82xx/Kconfig > @@ -31,6 +31,9 @@ config EP8248E > select 8260 > select FSL_SOC > select PHYLIB > + select NET > + select NETDEVICE > + select NET_SCHED > select MDIO_BITBANG > help > This enables support for the Embedded Planet EP8248E board.
Why is there a `select PHYLIB' at the platform level? Shouldn't it be in drivers/net/Kconfig, near the appropriate network driver? That way people can build kernels without networking support, if they want. With kind regards, Geert Uytterhoeven Software Architect Techsoft Centre Technology and Software Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: [email protected] Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 _______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
