Arnd Bergmann wrote:
> On Friday 22 May 2009, Wolfgang Grandegger wrote:
>> This patch adds a generic driver for SJA1000 chips on the OpenFirmware
>> platform bus found on embedded PowerPC systems.
>
> Nice driver!
>
>> +static u8 sja1000_ofp_read_reg(const struct net_device *dev, int reg)
>> +{
>> + return in_8((void __iomem *)(dev->base_addr + reg));
>> +}
>> +
>> +static void sja1000_ofp_write_reg(const struct net_device *dev, int reg, u8
>> val)
>> +{
>> + out_8((void __iomem *)(dev->base_addr + reg), val);
>> +}
>
> Minor nitpicking: dev->base_addr should be defined as an __iomem pointer
> so you can avoid the cast here and in the ioremap/iounmap path.
Here the member "base_addr" of "struct net_device" is used and it's not
up to me to change the type.
Wolfgang.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
