Dear Wolfram Sang, In message <20090717093307.gb3...@pengutronix.de> you wrote: > ... > > @@ -188,6 +209,12 @@ static struct of_device_id fs_enet_mdio_fec_match[] = { > > { > > .compatible = "fsl,pq1-fec-mdio", > > }, > > +#if defined(CONFIG_PPC_MPC512x) > > + { > > + .compatible = "fsl,mpc5121-fec-mdio", > > + .data = mpc5xxx_get_bus_frequency, > > + }, > > +#endif > > Grepping through 'drivers/*' I see that #ifdefing compatible-entries is highly > uncommon (just 3 hits). I think a guideline would be useful. Most people like > to avoid #ifdefs at any cost, while I personally think it doesn't spoil > readability too much here. Other opinions?
An older version of the patch tried to "hide" the ifdef in a 512x specific header, so at least common code would remain clean, but I agree with Grant that this current version looks cleaner globally. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "You can have my Unix system when you pry it from my cold, dead fingers." - Cal Keegan _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev