On Aug 19, 2009, at 7:43 PM, Benjamin Herrenschmidt wrote:

On Wed, 2009-08-19 at 16:37 -0500, Kumar Gala wrote:
On Aug 19, 2009, at 2:25 AM, Benjamin Herrenschmidt wrote:

The whole thing only ever gets called if we had tlbsrx. so is there
any utility in making a part of conditional on tlbsrx?

I don't think so ... this is the second level TLB miss handler when
the first level takes a hit on the virtually linear page tables, I
has nothing to do with tlbsrx... however, it does offset the return
address back into the first level handler by -4 to account for
replaying the tlbsrx instruction which you probably don't want to do.

Duh.  Wasn't looking at the fall through.

But is there any reason to even have any of the 6 instructions in the 'virt_page_table_tlb_miss_done' path if we don't have TLBSRX?

- k
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to