On Thu, Oct 8, 2009 at 11:14 PM, Wolfram Sang <w.s...@pengutronix.de> wrote: >> Will check this tomorrow. > > And while doing this and figuring the pro/cons of those methods, I stumbled > over this commit: > > gpio: pca953x: Get platform_data from OpenFirmware > (1965d30356c1c65660ba3330927671cfe81acdd5) > > It looks to me that it missed all people involved in OF/DT-development and > now we > have undocumented and IMO questionable properties in the kernel.
Hi Nate, For your future reference, patches that look at the device tree should also cc: devicetree-disc...@lists.ozlabs.org so that new bindings can be reviewed and common mistakes can be avoided. It is expected that new device tree bindings are accompanied with documentation describing what the binding is for and how it should be used (see Documentation/powerpc/dts-bindings). I know this change is already in mainline, but can you please post the device tree fragment that you're using to describe this chip? I want to make sure we don't get stuck with things in the kernel that will be hard to maintain in the long term. Thanks, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
