On Nov 30, 2009, at 10:23 PM, Albert Herranz wrote: > Richard Holden wrote: >> Albert Herranz wrote: > The first patch is generic, and uses PPC_EARLY_DEBUG. > This is the first patch where PPC_EARLY_DEBUG_USBGECKO is referenced.
Sorry, you are correct. >>> diff --git a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c >>> b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c >>> index ba4c7cc..3f125b6 100644 >>> --- a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c >>> +++ b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c >>> @@ -17,6 +17,7 @@ >>> #include <asm/io.h> >>> #include <asm/prom.h> >>> #include <asm/udbg.h> >>> +#include <asm/fixmap.h> >>> >>> #include "usbgecko_udbg.h" >>> >>> @@ -270,3 +271,61 @@ done: >>> of_node_put(np); >>> return; >>> } >>> + >>> +#ifdef CONFIG_PPC_EARLY_DEBUG_USBGECKO >>> + >>> +static void __init ug_early_remap(void) >> >> you may want to rename the ug_ prefix, it took me a while looking back >> and forth through the patch to convince myself it wasn't a typo. >> > > What's wrong with ug_ ? (ug = (u)sb(g)ecko) > At first look I thought it was a typo of udbg_early_remap. I prefer the longer names although we could use gecko_early_remap unless the gecko prefix conflicts with anything else. If there is not going to be a non usb gecko then there is no need to have usb in the prefix. -Richard Holden _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
