From: Márton Németh <nm...@freemail.hu> The match_table field of the struct of_device_id is constant in <linux/of_platform.h> so it is worth to make the initialization data also constant.
The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by: Márton Németh <nm...@freemail.hu> Cc: Julia Lawall <ju...@diku.dk> Cc: co...@diku.dk --- diff -u -p a/drivers/macintosh/therm_windtunnel.c b/drivers/macintosh/therm_windtunnel.c --- a/drivers/macintosh/therm_windtunnel.c 2010-01-07 19:08:40.000000000 +0100 +++ b/drivers/macintosh/therm_windtunnel.c 2010-01-08 04:47:10.000000000 +0100 @@ -457,7 +457,7 @@ therm_of_remove( struct of_device *dev ) return 0; } -static struct of_device_id therm_of_match[] = {{ +static const struct of_device_id therm_of_match[] = {{ .name = "fan", .compatible = "adm1030" }, {} diff -u -p a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c --- a/drivers/macintosh/smu.c 2009-12-03 04:51:21.000000000 +0100 +++ b/drivers/macintosh/smu.c 2010-01-08 04:47:28.000000000 +0100 @@ -660,7 +660,7 @@ static int smu_platform_probe(struct of_ return 0; } -static struct of_device_id smu_platform_match[] = +static const struct of_device_id smu_platform_match[] = { { .type = "smu", diff -u -p a/drivers/macintosh/therm_pm72.c b/drivers/macintosh/therm_pm72.c --- a/drivers/macintosh/therm_pm72.c 2009-12-03 04:51:21.000000000 +0100 +++ b/drivers/macintosh/therm_pm72.c 2010-01-08 04:50:17.000000000 +0100 @@ -2211,7 +2211,7 @@ static int fcu_of_remove(struct of_devic return 0; } -static struct of_device_id fcu_match[] = +static const struct of_device_id fcu_match[] = { { .type = "fcu", _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
