On Mon, Feb 8, 2010 at 7:09 AM, John Linn <john.l...@xilinx.com> wrote: >> -----Original Message----- >> From: John Linn [mailto:john.l...@xilinx.com] >> Sent: Friday, February 05, 2010 3:41 PM >> To: net...@vger.kernel.org; linuxppc-...@ozlabs.org; > jgar...@pobox.com; grant.lik...@secretlab.ca; >> jwbo...@linux.vnet.ibm.com >> Cc: john.willi...@petalogix.com; John Linn; Sadanand Mutyala >> Subject: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support >> >> These changes add MDIO and phy lib support to the driver as the >> IP core now supports the MDIO bus. >> >> The MDIO bus and phy are added as a child to the emaclite in the > device >> tree as illustrated below. >> >> mdio { >> #address-cells = <1>; >> #size-cells = <0>; >> compatible = "xlnx,emaclite-mdio"; >> phy0: p...@7 { >> reg = <7>; >> } ; >> }
You misunderstood me about the compatible property. You don't need a compatible prop in the mdio node because it is *alwasy* a child of the emaclite node, and the emaclite driver knows to go looking for it (ie. it is a part of the device). What I want to see is a compatible value in the p...@7 node for the make & model of the phy. Otherwise, looks good to me. Fix the mutex timeout problem and then you can add my acked-by line to the patch. Cheers, g. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
