On Mon, Feb 22, 2010 at 09:26:13PM +0100, Guennadi Liakhovetski wrote: > On Mon, 22 Feb 2010, Steven J. Magnani wrote: > > > diff -uprN a/include/linux/dmaengine.h b/include/linux/dmaengine.h > > --- a/include/linux/dmaengine.h 2010-02-22 11:18:11.000000000 -0600 > > +++ b/include/linux/dmaengine.h 2010-02-22 11:18:30.000000000 -0600 > > @@ -31,6 +31,8 @@ > > * if dma_cookie_t is >0 it's a DMA request cookie, <0 it's an error code > > */ > > typedef s32 dma_cookie_t; > > +#define DMA_MIN_COOKIE 1 > > +#define DMA_MAX_COOKIE 2147483647 > > Taking into account, that dma_cookie_t is 32 bits: > > +#define DMA_MAX_COOKIE ((1 << 31) - 1) >
Steven, After you take Guennadi's comment into acount, the rest of the patch looks good. I'm sure I've never rolled the cookie around during testing. Ira _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
